Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ubuntu 24.04 for GCE #1461

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add Ubuntu 24.04 for GCE #1461

merged 1 commit into from
Jun 13, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented May 3, 2024 •
edited
Loading

Change description

Adds image-builder support for GCE images for the new Ubuntu 24.04 LTS "Noble Numbat" release.

Related issues

Additional context

There isn't yet an official Ubuntu 24.04 image from Canonical at Google: https://console.cloud.google.com/compute/instances(cameo:browse)?hl=en&filter=solution-type:vm&q=ubuntu%2024.04
But when there is, this might work. 😄 I'll keep an eye out and retest when it's available.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2024
@mboersma
Copy link
Contributor Author

mboersma commented May 3, 2024

/retitle [WIP] Add Ubuntu 24.04 for GCE

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 3, 2024
@k8s-ci-robot k8s-ci-robot changed the title Add Ubuntu 24.04 for GCE [WIP] Add Ubuntu 24.04 for GCE May 3, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@mboersma
Copy link
Contributor Author

mboersma commented May 10, 2024 •
edited
Loading

"Ubuntu Pro 24.04 LTS" is available now on Google Cloud, but this PR needs the vanilla, non-"Pro" distro, as we've done for previous releases. ⏳

@mboersma mboersma added the kind/feature Categorizes issue or PR as related to a new feature. label May 10, 2024
@AverageMarcus
Copy link
Member

@mboersma It looks like Ubuntu 24.04 LTS is now available on GCP. Can we try and get this merged in today? I'd like to get it released. 😄

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@mboersma
Copy link
Contributor Author

@AverageMarcus there is a vanilla-type Ubuntu 24.04 image there now, but it's not maintained by Canonical, but by a third-party partner "Cloud Infrastructure Services." In the past, we've just used Canonical's image (which still doesn't exist yet except in a "Pro" edition).

So I think we should wait for an official Canonical base image. We could probably use this one, but I think we'd want to switch when Canonical's is published, so maybe it's safer to wait?

@AverageMarcus
Copy link
Member

I hadn't spotted that it wasn't from Canonical. I agree we should continue to wait.

@mboersma
Copy link
Contributor Author

It's been six weeks since 24.04 was released, and I'm not sure Canonical plans to make a vanilla (non-Pro) image available on GCE. This PR is based on their past behavior.

Does anyone know whom to contact to see if they plan to release a vanilla GCE image? Maybe we should consider their Pro image, or using a third-party vanilla image. I'm not sure what the tradeoffs are.

@mboersma
Copy link
Contributor Author

mboersma commented Jun 13, 2024 •
edited
Loading

On the "Ubuntu on Google Cloud" page, there is a link to run Ubuntu 24.04 LTS: Standard that seems to populate the image field with what we want. Maybe it's just not being listed in the Marketplace? I'll dig deeper.

Edit: found 24.04 LTS here.

@mboersma
Copy link
Contributor Author

Seems to work. I had to change the name of the image slightly as Canonical now appends -amd64 or -arm64.

%  make -C images/capi build-gce-ubuntu-2404
hack/ensure-python.sh
Checking if python is available
Python 3.12.3
hack/ensure-ansible.sh
hack/ensure-packer.sh
Packer is already installed, checking version...
existing packer version: 1.9.5
Packer version is as expected
Packer version 1.9.5 is already installed
hack/ensure-goss.sh
Right version of binary present
...
googlecompute.ubuntu-2404: output will be in this color.

==> googlecompute.ubuntu-2404: Checking image does not exist...
==> googlecompute.ubuntu-2404: Creating temporary RSA SSH key for instance...
==> googlecompute.ubuntu-2404: Using image: ubuntu-2404-noble-amd64-v20240607
==> googlecompute.ubuntu-2404: Creating instance...
    googlecompute.ubuntu-2404: Loading zone: us-central1-a
    googlecompute.ubuntu-2404: Loading machine type: n1-standard-1
    googlecompute.ubuntu-2404: Requesting instance creation...
    googlecompute.ubuntu-2404: Waiting for creation operation to complete...
    googlecompute.ubuntu-2404: Instance has been created!
==> googlecompute.ubuntu-2404: Waiting for the instance to become running...
    googlecompute.ubuntu-2404: IP: 34.123.194.133
==> googlecompute.ubuntu-2404: Using SSH communicator to connect: 34.123.194.133
==> googlecompute.ubuntu-2404: Waiting for SSH to become available...
==> googlecompute.ubuntu-2404: Connected to SSH!
==> googlecompute.ubuntu-2404: Provisioning with Ansible...
...
==> googlecompute.ubuntu-2404: Goss validate ran successfully
==> googlecompute.ubuntu-2404: 
==> googlecompute.ubuntu-2404: 
==> googlecompute.ubuntu-2404: 
==> googlecompute.ubuntu-2404: Downloading spec file and debug info
    googlecompute.ubuntu-2404: Downloading Goss specs from, /tmp/goss-spec.yaml and /tmp/debug-goss-spec.yaml to current dir
==> googlecompute.ubuntu-2404: Deleting instance...
    googlecompute.ubuntu-2404: Instance has been deleted!
==> googlecompute.ubuntu-2404: Creating image...
==> googlecompute.ubuntu-2404: Deleting disk...
    googlecompute.ubuntu-2404: Disk has been deleted!
Build 'googlecompute.ubuntu-2404' finished after 9 minutes 32 seconds.

image

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2024
@mboersma
Copy link
Contributor Author

/retitle Add Ubuntu 24.04 for GCE

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Add Ubuntu 24.04 for GCE Add Ubuntu 24.04 for GCE Jun 13, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@mboersma mboersma added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 13, 2024
AverageMarcus
AverageMarcus reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Ship it! :shipit:

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 589360d into kubernetes-sigs:main Jun 13, 2024
12 of 13 checks passed
@mboersma mboersma deleted the gce-ubuntu-2404 branch June 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AverageMarcus AverageMarcus AverageMarcus left review comments

@drew-viles drew-viles Awaiting requested review from drew-viles

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@AverageMarcus AverageMarcus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mboersma @AverageMarcus @k8s-ci-robot